zsh: realized some things need to be functions

By that, I mean things that change my working directory need to be
functions

.config/shell/bin/cds

@@ -1,18 +0,0 @@
-#!/bin/bash
-
-# cd search: cd to a directory, given part of its name
-# (also can take arguments for an `fd` commnd)
-# (also can cd to a file if `-t f` is passed)
-
-if ! [ -z "$1" ];then
-   DIR="$(fd --max-results=1 -t d $@)"
-   if [ -f "$DIR" ];then
-      cd "$(dirname "$DIR")" && pwd
-   else
-      cd "$DIR" && pwd
-   fi
-else
-   echo "$0: no arguments provided"
-   return 1
-fi
-

.config/shell/bin/error

@@ -3,6 +3,6 @@
 # for sending error messages from functions and whatnot
 
 ERROR_CODE="$?"
->&2 echo "An error occurred within a function in the .zshrc on line number ${1}"
+>&2 echo "$0: An error occurred on line number ${1}"
 return $ERROR_CODE
 

.config/shell/bin/ex

@@ -2,7 +2,7 @@
 
 # Simple extraction script. Taken from manjaro's .bashrc
 
-if [ -f $1 ] ; then
+if [ -f "$1" ] ; then
    case $1 in
       *.tar.bz2)   tar xjf "$1"   ;;
       *.tar.gz)    tar xzf "$1"   ;;

.config/shell/bin/gloned

@@ -1,15 +0,0 @@
-#!/bin/bash
-
-# Git cLONE cD
-# Can take extra arguments for git (ex: gloned url:/repo folder)
-
-# shellcheck disable=SC2068,SC2016
-
-git clone $@ || return $?
-if ! cd "$(echo "$1" | sed 's/\.git//g' | rev | cut -d '/' -f 1 | rev)";then
-   echo 'Error: Could not `cd` into the repo'
-   return 1
-fi
-echo
-# ls --color=auto
-

.config/shell/bin/sitepath

@@ -6,18 +6,18 @@
 # usage: sitepath
 # usage: sitepath <fd commands> -- you can search with 'fd' if you put in a command
 
-   # account for if there is no urlencode command
-   URLENCODE=urlencode
-   if ! command -v urlencode > /dev/null 2>&1;then
-      URLENCODE=cat
-   fi
-   # If there is no input, make the input the current directory
-   [ -z ${1+x} ] && 1="$(pwd)"
-   FILEPATH="$(([ -e "$1" ] && readlink -f "$1") || fd $@ /home/blake/docker/blakenorth.net/site)"
+# account for if there is no urlencode command
+URLENCODE=urlencode
+if ! command -v urlencode > /dev/null 2>&1;then
+   URLENCODE=cat
+fi
+# If there is no input, make the input the current directory
+[ -z ${1+x} ] && 1="$(pwd)"
+FILEPATH="$(([ -e "$1" ] && readlink -f "$1") || fd $@ /home/blake/docker/blakenorth.net/site)"
 
-   # change all file paths into urls
-   echo "$FILEPATH" |
-      grep -o 'site.*' |
-      sed 's+^site+https://blakenorth.net+g' |
-      $URLENCODE # if you need this, I am using dead10ck/urlencode (cargo install urlencode)
+# change all file paths into urls
+echo "$FILEPATH" |
+   grep -o 'site.*' |
+   sed 's+^site+https://blakenorth.net+g' |
+   $URLENCODE # if you need this, I am using dead10ck/urlencode (cargo install urlencode)
 

.config/shell/functions/cda

@@ -10,7 +10,9 @@
 # (although that wouldn't be as good as recording actions bc it's easy to do
 # that by just writing a for loop)
 
-for DIR in *; do
-   (cd "$DIR" && zsh)
-done
+cda() {
+   for DIR in *; do
+      (cd "$DIR" && zsh)
+   done
+}
 

.config/shell/functions/cdf

@@ -4,11 +4,11 @@
 # Basically, an interactive version of what's above
 # can take an `fd` command
 # requires that `fzy` is installed
-
-DIR="$(fd $@ | fzy)"
-if [ -f "$DIR" ];then
-   cd "$(dirname "$DIR")" && pwd
-else
-   cd "$DIR" && pwd
-fi
-
+cdf() {
+   DIR="$(fd $@ | fzy)"
+   if [ -f "$DIR" ];then
+      cd "$(dirname "$DIR")" && pwd
+   else
+      cd "$DIR" && pwd
+   fi
+}

.config/shell/functions/cds

@@ -0,0 +1,20 @@
+#!/bin/bash
+
+# cd search: cd to a directory, given part of its name
+# (also can take arguments for an `fd` commnd)
+# (also can cd to a file if `-t f` is passed)
+
+cds() {
+   if ! [ -z "$1" ];then
+      DIR="$(fd --max-results=1 -t d $@)"
+      if [ -f "$DIR" ];then
+         cd "$(dirname "$DIR")" && pwd
+      else
+         cd "$DIR" && pwd
+      fi
+   else
+      echo "$0: no arguments provided"
+      return 1
+   fi
+}
+

.config/shell/functions/gloned

@@ -0,0 +1,20 @@
+#!/bin/bash
+
+# Git cLONE cD
+# Can take extra arguments for git (ex: gloned url:/repo folder)
+
+# shellcheck disable=SC2068,SC2016
+
+gloned() {
+   # remove the url up to the last segment, and remove the .git from the end
+   REPO_DIR="${2:-"$(echo "${1%%.git}" | rev | cut -d '/' -f 1 | rev)"}"
+
+   git clone "$1" "$REPO_DIR" || exit $?
+   ls
+   if ! cd "$REPO_DIR";then
+      echo 'Error: Could not `cd` into the repo'
+      exit 1
+   fi
+   echo
+   # ls --color=auto
+}

.config/shell/functions/todo

@@ -9,12 +9,12 @@
 # Suggested use: make a git repo for holding your todo list, then make
 # a symlink called 'todo' that points to your todo list in your home directory
 #
-
-todo_dir="$(dirname "$(realpath ~/todo)")"
-todo_file="$(realpath ~/todo)"
-if [ -z "$@" ];then
-   ( # subshell to protect against directory changes
-   cd "$todo_dir"
+todo() {
+   todo_dir="$(dirname "$(realpath ~/todo)")"
+   todo_file="$(realpath ~/todo)"
+   if [ -z "$*" ];then
+      ( # subshell to protect against directory changes
+      cd "$todo_dir" || exit
 
       # pull the latest commits
       git rev-parse &&
@@ -28,13 +28,11 @@ if [ -z "$@" ];then
          git commit "$todo_file" -m 'todo' &&
             git push
       fi
-   )
-
-elif [ "$@" = "cd" ]; then
-   cd "$todo_dir"
-
-else
-   git -C "$todo_dir" $@
-
-      fi
+      )
 
+   elif [ "$*" = "cd" ]; then
+      cd "$todo_dir" || exit
+   else
+      git -C "$todo_dir" $@
+   fi
+}